fix: public ENV replacement in next client components#508
Open
melkir wants to merge 1 commit intodmno-dev:mainfrom
Open
fix: public ENV replacement in next client components#508melkir wants to merge 1 commit intodmno-dev:mainfrom
melkir wants to merge 1 commit intodmno-dev:mainfrom
Conversation
|
515049a to
e03b950
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix public
ENV.*replacement in Next client components.Previously, the Next loader returned early for
'use client'modules, which meant Turbopack client code skipped the non-sensitive static replacement pass entirely.What changed
ENV.*replacement path still runs thereRoot cause
Two things combined to break
ENV.NEXT_PUBLIC_*in client components under Turbopack:That left
ENV.NEXT_PUBLIC_*as a runtime lookup in client code instead of being inlined like other public env access.Impact
Client code can now read public env values through
ENV.NEXT_PUBLIC_*under Turbopack without pulling in the server-only init snippet.