matej/vscode-diagnostics-comment-awareness#467
Open
voiys wants to merge 6 commits intodmno-dev:mainfrom
Open
Conversation
🦋 Changeset detectedLatest commit: d9f9160 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
philmillman
approved these changes
Mar 23, 2026
theoephraim
approved these changes
Mar 24, 2026
theoephraim
approved these changes
Mar 24, 2026
| expect(diagnostics).toEqual([]); | ||
| }); | ||
|
|
||
| it('ignores parser-style ignored decorator comments', () => { |
Member
There was a problem hiding this comment.
Not sure about this. The real loader will explode when it sees this with an "unknown decorator" kind of error. Maybe we should allow them as noops since they are common though. But either way it should match.
| @@ -0,0 +1,2 @@ | |||
| --- | |||
Member
There was a problem hiding this comment.
you can add a changeset with the vscode extension tagged. It will merge them all up when we publish together
commit: |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
@@decoratoror@type=...from triggering VS Code diagnostics/type validationTest plan
bunx vitest packages/vscode-plugin/test/diagnostics-core.test.tsbun run lint:fixExamples: