Skip to content

Upgrade TypeScript ESLint to 8.60.1 and add pnpm overrides#342

Open
dmnktoe wants to merge 1 commit into
mainfrom
claude/zealous-wright-pYxOU
Open

Upgrade TypeScript ESLint to 8.60.1 and add pnpm overrides#342
dmnktoe wants to merge 1 commit into
mainfrom
claude/zealous-wright-pYxOU

Conversation

@dmnktoe
Copy link
Copy Markdown
Owner

@dmnktoe dmnktoe commented Jun 3, 2026

Summary

This PR updates the TypeScript ESLint tooling dependencies and adds pnpm package overrides to ensure consistent versions across the dependency tree.

Key Changes

  • Upgraded @typescript-eslint/eslint-plugin, @typescript-eslint/parser, and typescript-eslint from 8.59.4 to 8.60.1
  • Added pnpm.overrides configuration to enforce consistent versions of TypeScript ESLint packages across all transitive dependencies
  • Fixed English comment in eslint.config.js ("bringt Plugin + Rules mit" → "provides plugin + rules")

Implementation Details

The pnpm overrides ensure that all dependencies in the tree use the same versions of the TypeScript ESLint packages, preventing version conflicts and ensuring consistent linting behavior across the project.

https://claude.ai/code/session_01AvthvYNhWdehGXzmQAUpLg

Summary by CodeRabbit

  • Chores
    • Updated TypeScript-ESLint ecosystem packages to version 8.60.1, including the main plugin, parser, and related packages for improved tooling
    • Enhanced linting configuration with recommended TypeScript rule enforcement to strengthen code quality and consistency standards
    • Updated package override specifications to ensure consistent tool versions across all project dependencies

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

Warning

Review limit reached

@dmnktoe, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 56 minutes and 20 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 707e3d4b-40b8-41ae-b3a3-b871412f5b0d

📥 Commits

Reviewing files that changed from the base of the PR and between 9c98f90 and b365ced.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • eslint.config.js
  • package.json
📝 Walkthrough

Walkthrough

This PR upgrades the project's TypeScript-ESLint dependencies from version 8.59.4 to 8.60.1 and updates the ESLint configuration to use the TypeScript-ESLint recommended preset with an inline comment. All related packages are synchronized across devDependencies and pnpm.overrides.

Changes

TypeScript-ESLint Configuration and Dependency Upgrade

Layer / File(s) Summary
ESLint config and dependency versions
eslint.config.js, package.json
The ESLint flat config is updated to spread tseslint.configs.recommended, and @typescript-eslint/eslint-plugin, @typescript-eslint/parser, and typescript-eslint are bumped to version 8.60.1 in both devDependencies and pnpm.overrides.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • dmnktoe/sentiment#324: Both PRs modify the package.json dependency setup for typescript-eslint via the pnpm.overrides/devDependencies versioning, so the changes may have conflicting or sequential dependency management.

Poem

🐰 A hop, skip, and version bump today,
ESLint rules now configured the recommended way,
Eight-sixty-one brings harmony to the linted line,
TypeScript checks now aligned and fine! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately summarizes the main changes: upgrading TypeScript ESLint to 8.60.1 and adding pnpm overrides, which aligns with both the package.json and eslint.config.js modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/zealous-wright-pYxOU

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sentry
Copy link
Copy Markdown

sentry Bot commented Jun 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.04%. Comparing base (8ddd3f0) to head (b365ced).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #342   +/-   ##
=======================================
  Coverage   67.04%   67.04%           
=======================================
  Files          67       67           
  Lines         789      789           
  Branches      175      169    -6     
=======================================
  Hits          529      529           
  Misses        260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dmnktoe dmnktoe force-pushed the claude/zealous-wright-pYxOU branch 3 times, most recently from 7327612 to c9d6e34 Compare June 3, 2026 13:45
The config spread both eslint-config-next and our own typescript-eslint, each
registering the @typescript-eslint plugin. As two separate installs they became
distinct instances and ESLint flat config crashed with "Cannot redefine plugin"
whenever the versions drifted apart (e.g. the 8.60 bump).

Switch to the native Next.js setup: spread next/core-web-vitals + next/typescript
(the latter already bundles the typescript-eslint recommended rules) and drop the
direct @typescript-eslint/* and typescript-eslint dependencies. Now a single
typescript-eslint instance (provided transitively by Next) is in play, so the
crash cannot recur and no pnpm override is needed.
@dmnktoe dmnktoe force-pushed the claude/zealous-wright-pYxOU branch from c9d6e34 to b365ced Compare June 3, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants