forked from gallantlab/pycortex
-
Notifications
You must be signed in to change notification settings - Fork 0
Blender flattening support #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dmitry-mli
wants to merge
12
commits into
main
Choose a base branch
from
blender-flattening-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcneil
approved these changes
Jun 6, 2025
cmcneil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me! Minor nits, but seems like an overall generalization with some improvements to code quality.
8cf08a1 to
ac7f097
Compare
Some of these are quite nice to have when doing retinotopy.
* working clipping * cleaned up shaders * added comments --------- Co-authored-by: Alexander Huth <huth@wireless-10-154-98-148.public.utexas.edu> Co-authored-by: Alexander Huth <huth@wireless-10-145-16-120.public.utexas.edu>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…lab#577) * deal with xdrlib import for blender interpreter * fix import statement for blender
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5 to 6. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v5...v6) --- updated-dependencies: - dependency-name: actions/setup-python dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
adb55bd to
46ee94a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
cortex.blender.blendlib.py. It follows the same selection as for the volume mesh. This is accessible viawrite_flat_patch.write_flat_patchand the old one, renamedsave_patchintowrite_volume_patch._get_pts_edgesinto_get_geometryfor clarity. Added clarifying logging and elapsed time tracking. Extended docstring.mda_xdrlibthat was removed from Python 3.13.cortex.blender._call_blender to support non-code calls to Blender to reduces confusion and improves code clarity. Refactoredfs_cutintofs_cut_initand added a newfs_cut_open` to improve clarity. Extended docstring.cut_surfacefor clarity. Onboarded torecacheflag to support forced generation.”and"which may result into code examples not running properly.Tutorial video
As different labs may approach cuts slightly differently, created and edited a tutorial video instruction that follows the style of gallantlab.org. The used anatomy was taken from Horikawa, T., Cowen, A. S., Keltner, D., & Kamitani, Y. (2020). The neural representation of visually evoked emotion is high-dimensional, categorical, and distributed across transmodal brain regions..
Docs update
Added a new section on the cuts. When rendered looks as follows: