You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There was a bug in the generated code that I fixed, but it's all working now and we are using in production.
Mostly, I was unsure if you were open to taking it because adding the extra flag to main seemed to tip your code coverage tool over the threshold. I'll re-open if you are.
When I look though the code, it looked just fine I was more concerned about the introduction of a 3rd party include github.com/gocql/gocql currently I think everything we use is internal, my luck the next person will want to add some other cql library! Really wish the UnmarshalCQL did not require gocql.TypeInfo 😢 I guess if you have it all working and your happy with it, open it up maybe I can take some time try to get the coverage figured out.
Will do. Yeah, the dependency is not ideal -- especially since we don't care about supporting non-string CQL types -- but if it makes you feel better gocql is a low-level package for CQL which all the other ORM-like packages depend on. It's unlikely to be displaced for at least for a few years and TypeInfo is an interface so things still work with any forks. The ScyllaDB guys (they are a Go shop, for everything except the core DB) maintain a fork of gocql for gocqlx which we use and there are no issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for CQL which is used by Cassandra, ScyllaDB, YugeByte, etc. Works similarly to json in that it adds Marshal and Unmarshal methods.