fix(file_history): position cursor on active item when panel starts open#166
Merged
dlyongemallo merged 1 commit intomainfrom May 8, 2026
Merged
fix(file_history): position cursor on active item when panel starts open#166dlyongemallo merged 1 commit intomainfrom
dlyongemallo merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts the FileHistory view’s panel refresh/bootstrap logic so that when the file history panel starts open, the cursor can be positioned on the active item (by ensuring the panel is fully synced before the initial item selection/highlight occurs).
Changes:
- Call
FileHistoryPanel:sync()unconditionally during throttled PROGRESS rendering inupdate_entries(). - Remove the prior special-case
update_components()call on the “no current file yet” bootstrap path, and rely onsync()instead.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+273
to
276
| self:sync() | ||
| if not self:cur_file() then | ||
| self:update_components() | ||
| self.parent:next_item() | ||
| else | ||
| self:sync() | ||
| end |
dlyongemallo
force-pushed
the
file_history_panel_cursor
branch
from
ef6ecc2 to
d983966
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #161.