fix(panel): position cursor on active file when toggling panel open#164
Merged
dlyongemallo merged 1 commit intomainfrom May 7, 2026
Merged
fix(panel): position cursor on active file when toggling panel open#164dlyongemallo merged 1 commit intomainfrom
dlyongemallo merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes the inconsistency described in #161 where opening the file panel via :DiffviewToggleFiles (when file_panel.show = false) would not position the cursor on the currently active file entry.
Changes:
- Update
FilePanel:open()to re-highlight (and thus reposition the cursor on) the current active file when the panel transitions from closed → open. - Add a functional regression test ensuring toggling the panel open places the cursor on the active file entry.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lua/diffview/scene/views/diff/file_panel.lua | Ensures open() positions the cursor on the active file by calling highlight_cur_file(). |
| lua/diffview/tests/functional/cdiff_view_spec.lua | Adds a regression test for cursor positioning when the panel is toggled open with file_panel.show = false. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
212d0f3 to
57bb570
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #161.