Early stage bindings for std::unordered_map on linux #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 8, 2024 03:11
This serves as the beginning module for unordered_map container. currently, this serves only Gcc runtime with the possible bindable functions for now
Emmankoko
force-pushed
the
linux/unordered_map
branch
3 times, most recently
from
6f130d0 to
3cc444f
Compare
Emmankoko
force-pushed
the
linux/unordered_map
branch
from
3cc444f to
aac8641
Compare
Geod24
reviewed
Mar 8, 2024
source/stdcpp/unordered_map.d
Outdated
| @@ -0,0 +1,103 @@ | |||
| /** | |||
| * D header file for interaction with C++ std::unordered_map. | |||
| * | |||
Member
There was a problem hiding this comment.
See_Also:
https://en.cppreference.com/w/cpp/container/unordered_map
source/stdcpp/unordered_map.d
Outdated
Comment on lines
19
to
20
| alias unordered_map(Key, value) = unordered_map!(Key, value, hash!Key, equal_to!Key, allocator!(pair!(const(Key), value))); | ||
| extern(C++, class) struct unordered_map(Key, value, Hash, KeyEqual, Alloc) |
Member
There was a problem hiding this comment.
Use default parameter for better API.
Suggested change
| alias unordered_map(Key, value) = unordered_map!(Key, value, hash!Key, equal_to!Key, allocator!(pair!(const(Key), value))); | |
| extern(C++, class) struct unordered_map(Key, value, Hash, KeyEqual, Alloc) | |
| extern(C++, class) struct unordered_map(Key, value, Hash = hash!Key, KeyEqual = equal_to!Key, Alloc = allocator!(pair!(const(Key), value))) |
Unless that does not work ?
Comment on lines
52
to
57
| /// | ||
| extern(D) this(const ref unordered_map __a) | ||
| { | ||
| allocator_type alloc_instance = allocator_type.init; | ||
| this(__a, alloc_instance); | ||
| } |
Comment on lines
42
to
50
| /// | ||
| extern(D) this(size_type __x) | ||
| { | ||
| allocator_type alloc_instance = allocator_type.init; | ||
| Hash hash_instance = Hash.init; | ||
| key_equal equal_instance = key_equal.init; | ||
| this(__x, hash_instance, equal_instance, alloc_instance); | ||
| } | ||
| /// |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is broken down into three simple commits on the following
std::unordered_maptargetingCppRuntime_Gccstdcpp.Hashtablemodule for unordered_map. it is imported in stdcpp.unordered_map module for a better code organization