Move emplace to core/lifetime #6881
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your pull request and interest in making D better, @edi33416! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#6881" |
PetarKirov
reviewed
Feb 27, 2019
std/conv.d
Outdated
| assert(iss.ii == [1, 2]); | ||
| } | ||
| /// ditto | ||
| T emplace(T, Args...)(T chunk, auto ref Args args); |
Member
There was a problem hiding this comment.
Don't forget to include the template constraints for the docs - e.g. if (is(T == class)), IIRC, for this overload.
Contributor
Author
There was a problem hiding this comment.
I don't think I can add the template constraint in the function declaration. I tried to do that, but I couldn't get it to compile.
Member
There was a problem hiding this comment.
Since this will only exist when building the docs, you can use a full function definition with a trivial body - e.g. { return chunk; }
Contributor
Author
There was a problem hiding this comment.
@ZombineDev added the template constraints for the docs.
edi33416
force-pushed
the
move_emplace_ref
branch
from
f85acb3 to
e799105
Compare
Member
|
On the auto tester there were a couple of OOM failures which I restarted, but also one failure on Windows: On BuildKite there the following two errors: (when building the druntime benchmark, which uses phobos) and: (simply style check warnings) |
Collaborator
|
This has been done in: #7745 . Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove code duplication by using the
druntimecore.lifetimeimplementation.This depends on this PR.