Refactor std.internal.entropy to provide reusable handles#10843
Draft
0xEAB wants to merge 8 commits intodlang:masterfrom
Draft
Refactor std.internal.entropy to provide reusable handles#108430xEAB wants to merge 8 commits intodlang:masterfrom
std.internal.entropy to provide reusable handles#108430xEAB wants to merge 8 commits intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @0xEAB! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#10843" |
LightBender
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
std.internal.entropyto provide reusable handles.This allows a more efficient use of the module on certain platforms (for future code).
To be fair, it might also make it slightly less efficient on others (e.g. Windows), though I think the reduction of TLS variables there might also be an improvement.
Please do not merge this yet. It needs further testing (that I haven’t performed yet).
Also, I’d prefer v2.112.0 to have the non-handle version of module which should be easier to deal with in case of any regressions that may arise.