Skip to content

Implementation of diagnostic reporting style for dfa engine#23124

Closed
Iskaban10 wants to merge 2 commits into
dlang:masterfrom
Iskaban10:diagreport
Closed

Implementation of diagnostic reporting style for dfa engine#23124
Iskaban10 wants to merge 2 commits into
dlang:masterfrom
Iskaban10:diagreport

Conversation

@Iskaban10
Copy link
Copy Markdown
Contributor

Diagnostic reporting mechanism. Can be used with -verror-style = diagreport. Code taken from here.
Example output:

image

Previous PR became messy. Hence made another PR.

@Iskaban10 Iskaban10 requested a review from ibuclaw as a code owner May 12, 2026 18:30
@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @Iskaban10! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#23124"

@dkorpel
Copy link
Copy Markdown
Contributor

dkorpel commented May 12, 2026

Can you please force push a new branch instead of opening new PRs? That prevents review comments getting erased.

Copy link
Copy Markdown
Contributor

@dkorpel dkorpel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Iskaban10
Copy link
Copy Markdown
Contributor Author

Can you please force push a new branch instead of opening new PRs? That prevents review comments getting erased.

Was facing some issue in re-opening the previous PR. I was not very familiar with managing git histories.
Closing this PR because I have been able to re-open the original PR.

@Iskaban10 Iskaban10 closed this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants