Fix properties with default value = true, add group options#7
Open
ootwch wants to merge 2 commits intodivshot:masterfrom
Open
Fix properties with default value = true, add group options#7ootwch wants to merge 2 commits intodivshot:masterfrom
ootwch wants to merge 2 commits intodivshot:masterfrom
Conversation
added 2 commits
September 12, 2015 12:40
Polymer properties with default value = true have to use Type: Object, otherwise it will not work. See also: Polymer/polymer#1812 (comment)
Two additional published properties 'push' and 'pull' Quote from Sortable Wiki https://github.com/RubaXa/Sortable/wiki/Sortable-v1.0-%E2%80%94-New-capabilities: pull — an ability to “pull out” elements during their movement between lists; also this property may have clone value; put — an ability to accept an element from another group, or an array of permitted groups. In order for clone to work the element properties are also explicitly copied on sort-start (Polymer/polymer#2112).
ootwch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix properties with default value = true
Polymer properties with default value = true have to use Type: Object, otherwise it will not work.
See also: Polymer/polymer#1812 (comment)
Support group options:
Two additional published properties 'push' and 'pull'
Quote from Sortable Wiki https://github.com/RubaXa/Sortable/wiki/Sortable-v1.0-%E2%80%94-New-capabilities:
pull — an ability to “pull out” elements during their movement between lists; also this property may have clone value;
put — an ability to accept an element from another group, or an array of permitted groups.
In order for clone to work the element properties are also explicitly copied on sort-start (Polymer/polymer#2112).