Fix authentication challenge completion handler not being called#35
Open
Eli-Liebman wants to merge 1 commit intodivar-ir:masterfrom
Open
Conversation
The urlSession(_:didReceive:completionHandler:) method was only calling the completionHandler for NSURLAuthenticationMethodServerTrust challenges when serverTrust was non-nil. This caused other authentication methods (e.g., NSURLAuthenticationMethodClientCertificate) to hang indefinitely as the completionHandler was never invoked. Added fallback to ensure completionHandler is always called with .performDefaultHandling for unhandled cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I ran into an issue where requests using client certificate authentication were hanging indefinitely when NetShears was enabled.
After digging in, I found that the
urlSession(_:didReceive:completionHandler:)method only calls thecompletionHandlerwhen the authentication method isNSURLAuthenticationMethodServerTrustand serverTrust is non-nil. For any other authentication type (likeNSURLAuthenticationMethodClientCertificate), the completion handler never gets called and the connection hangs/timeouts.This PR adds a fallback at the end of the method that calls
completionHandler(.performDefaultHandling, nil)for any cases that aren't explicitly handled, which lets the system handle them normally.