feat:Add forcefield node #2306
Open
feat:Add forcefield node #2306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 0d2f39a | Previous: 0586b47 | Ratio |
|---|---|---|---|
BM_Box_MinimumImage<CubicBox> |
45.52928342670042 ns/iter |
13.538990220747714 ns/iter |
3.36 |
BM_Box_MinimumVector<CubicBox> |
32.290840312019476 ns/iter |
10.377495200721015 ns/iter |
3.11 |
BM_Box_MinimumImage<OrthorhombicBox> |
45.62757135382433 ns/iter |
13.690692698626753 ns/iter |
3.33 |
BM_Box_MinimumVector<OrthorhombicBox> |
29.70491768386288 ns/iter |
10.39557174339636 ns/iter |
2.86 |
BM_Box_MinimumImage<MonoclinicAlphaBox> |
36.16111809383352 ns/iter |
11.623902510762226 ns/iter |
3.11 |
BM_Box_MinimumVector<MonoclinicAlphaBox> |
21.842464358541722 ns/iter |
6.070117054871113 ns/iter |
3.60 |
BM_Box_MinimumImage<TriclinicBox> |
36.65869605854782 ns/iter |
12.12782454035921 ns/iter |
3.02 |
BM_Box_MinimumVector<TriclinicBox> |
23.40155018950095 ns/iter |
6.743094983579432 ns/iter |
3.47 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @disorderedmaterials/dissolve-devs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a forcefield node, as well as a GUI to add the node and a test. I've also independently tested that the forcefield nodes can be saved to a file.