Skip to content

DEV: Update linting config and run gjs-codemod #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidtaylorhq merged 1 commit into from
Jun 6, 2025
Merged

DEV: Update linting config and run gjs-codemod #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .discourse-compatibility
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
< 3.5.0.beta5-dev: aab95d583a13ba44e2d2623c6799e7b55c223e6b
< 3.5.0.beta1-dev: 75feeaef864d679109eef618432454f3cf0fc3d3
< 3.4.0.beta1-dev: e7038201a59c0b320f13714f31a0b79d2a70bbc0
< 3.3.0.beta1-dev: 8672025433ec51a658a4a85479940492262773b5
Expand Down
36 changes: 18 additions & 18 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,41 +15,41 @@ GEM
tzinfo (~> 2.0, >= 2.0.5)
uri (>= 0.13.1)
ast (2.4.3)
base64 (0.2.0)
benchmark (0.4.0)
bigdecimal (3.1.9)
base64 (0.3.0)
benchmark (0.4.1)
bigdecimal (3.2.2)
concurrent-ruby (1.3.5)
connection_pool (2.5.0)
drb (2.2.1)
connection_pool (2.5.3)
drb (2.2.3)
i18n (1.14.7)
concurrent-ruby (~> 1.0)
json (2.10.2)
language_server-protocol (3.17.0.4)
json (2.12.2)
language_server-protocol (3.17.0.5)
lint_roller (1.1.0)
logger (1.7.0)
minitest (5.25.5)
parallel (1.26.3)
parser (3.3.7.3)
parallel (1.27.0)
parser (3.3.8.0)
ast (~> 2.4.1)
racc
prettier_print (1.2.1)
prism (1.4.0)
racc (1.8.1)
rack (3.1.12)
rack (3.1.16)
rainbow (3.1.1)
regexp_parser (2.10.0)
rubocop (1.75.1)
rubocop (1.76.0)
json (~> 2.3)
language_server-protocol (~> 3.17.0.2)
lint_roller (~> 1.1.0)
parallel (~> 1.10)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 2.9.3, < 3.0)
rubocop-ast (>= 1.43.0, < 2.0)
rubocop-ast (>= 1.45.0, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 4.0)
rubocop-ast (1.43.0)
rubocop-ast (1.45.0)
parser (>= 3.3.7.2)
prism (~> 1.4)
rubocop-capybara (2.22.1)
Expand All @@ -67,13 +67,13 @@ GEM
rubocop-factory_bot (2.27.1)
lint_roller (~> 1.1)
rubocop (~> 1.72, >= 1.72.1)
rubocop-rails (2.30.3)
rubocop-rails (2.32.0)
activesupport (>= 4.2.0)
lint_roller (~> 1.1)
rack (>= 1.1)
rubocop (>= 1.72.1, < 2.0)
rubocop-ast (>= 1.38.0, < 2.0)
rubocop-rspec (3.5.0)
rubocop (>= 1.75.0, < 2.0)
rubocop-ast (>= 1.44.0, < 2.0)
rubocop-rspec (3.6.0)
lint_roller (~> 1.1)
rubocop (~> 1.72, >= 1.72.1)
rubocop-rspec_rails (2.31.0)
Expand All @@ -100,4 +100,4 @@ DEPENDENCIES
syntax_tree

BUNDLED WITH
2.6.6
2.6.9
20 changes: 10 additions & 10 deletions common/common.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,20 +35,20 @@ p {
border-bottom-style: solid;
border-bottom-color: transparent;
padding: 0.75em 1.5em;
color: color.adjust($primary, $lightness: 30);
color: color.adjust($primary, $lightness: 30%);
text-transform: uppercase;
font-size: 0.75rem;
letter-spacing: 0.05em;
line-height: 1.7rem;

&:hover {
border-bottom-color: color.adjust($tertiary, $lightness: 40);
border-bottom-color: color.adjust($tertiary, $lightness: 40%);
background-color: transparent;
color: var(--primary);
}

&.active {
color: color.adjust($primary, $lightness: 0);
color: color.adjust($primary, $lightness: 0%);
background-color: transparent;
border-bottom-color: $tertiary;
font-weight: bold;
Expand Down Expand Up @@ -140,7 +140,7 @@ ol.category-breadcrumb {
}

#list-area .show-more.has-topics .alert {
background-color: rgba(240, 239, 246, 1);
background-color: rgb(240, 239, 246, 1);
border-radius: 2rem;
align-items: center;
position: relative;
Expand All @@ -157,7 +157,7 @@ ol.category-breadcrumb {
}

&:hover {
background-color: rgba(240, 239, 246, 0.6);
background-color: rgb(240, 239, 246, 0.6);
text-decoration: underline;
}
}
Expand Down Expand Up @@ -290,7 +290,7 @@ ol.category-breadcrumb {
border-radius: 50%;
height: 65px;
width: 65px;
box-shadow: inset -2px 0 5px rgba(0, 0, 0, 0.3);
box-shadow: inset -2px 0 5px rgb(0, 0, 0, 0.3);
}

.badge-contents .badge-icon.badge-type-bronze a {
Expand All @@ -310,7 +310,7 @@ ol.category-breadcrumb {
}

.badge-summary {
color: color.adjust($primary, $lightness: 30);
color: color.adjust($primary, $lightness: 30%);
}

.badge-contents .badge-info h3 {
Expand Down Expand Up @@ -353,7 +353,7 @@ ol.category-breadcrumb {
h3 {
font-size: 1rem;
font-weight: normal;
color: color.adjust($primary, $lightness: 40);
color: color.adjust($primary, $lightness: 40%);

&::after {
content: "✨";
Expand All @@ -374,7 +374,7 @@ ol.category-breadcrumb {
display: flex;
justify-content: center;
align-items: center;
color: color.adjust($primary, $lightness: 40);
color: color.adjust($primary, $lightness: 40%);
background-color: transparent;

&::after {
Expand All @@ -387,7 +387,7 @@ ol.category-breadcrumb {
.select-kit-body {
border: none;
background-color: var(--main-background);
box-shadow: 0 12px 12px rgba(0, 0, 0, 0.15);
box-shadow: 0 12px 12px rgb(0, 0, 0, 0.15);
}
}

Expand Down
4 changes: 2 additions & 2 deletions desktop/desktop.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
&.list-container,
.user-content {
border-radius: 0 0.5rem 0.5rem 0.5rem;
box-shadow: 0 15px 27px rgba(17, 7, 60, 0.15);
box-shadow: 0 15px 27px rgb(17, 7, 60, 0.15);
}

&.list-container {
Expand All @@ -16,7 +16,7 @@
background: var(--main-background);
padding: 1.5rem 2.5rem;
border-radius: 0.5rem;
box-shadow: 0 15px 27px rgba(17, 7, 60, 0.15);
box-shadow: 0 15px 27px rgb(17, 7, 60, 0.15);
}
}
}
Expand Down
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"private": true,
"devDependencies": {
"@discourse/lint-configs": "2.11.1",
"ember-template-lint": "7.0.1",
"eslint": "9.22.0",
"@discourse/lint-configs": "2.25.0",
"ember-template-lint": "7.8.1",
"eslint": "9.28.0",
"prettier": "3.5.3",
"stylelint": "16.16.0"
"stylelint": "16.20.0"
},
"engines": {
"node": ">= 22",
Expand Down
Loading