Revert "DEV: Pin playwright browser cache path in discourse_test image (#1058)"#1060
Merged
Merged
Conversation
nattsw
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1058. The image build failed because the subsequent
pnpm playwright install ffmpegstep still ran as root and created/home/discourse/.cache/ms-playwrightowned by root, breaking the chromium install that ran as the discourse user withEACCES: permission denied. See https://github.com/discourse/discourse_docker/actions/runs/26201953575.Reverting so
discourse_test:releasereturns to a known-good state. A combined re-introduction PR will follow with the ffmpeg install also running as the discourse user.