Skip to content

Drop removed bundler flags#1056

Closed
davidtaylorhq wants to merge 1 commit into
mainfrom
drop-deprecated
Closed

Drop removed bundler flags#1056
davidtaylorhq wants to merge 1 commit into
mainfrom
drop-deprecated

Conversation

@davidtaylorhq
Copy link
Copy Markdown
Member

No description provided.

@davidtaylorhq davidtaylorhq changed the title Drop deprecated bundler flags Drop removed bundler flags May 20, 2026
RUN --mount=type=bind,src=/repo,from=repo-fetcher,target=/tmp/discourse-clone,readwrite \
cd /tmp/discourse-clone \
&& bundle install --deployment \
&& bundle config set deployment && \
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this not be bundle config set deployment true as per the error message?

@fitzy101
Copy link
Copy Markdown
Contributor

fitzy101 commented May 20, 2026

Might be easier to use env BUNDLE_DEPLOYMENT=true bundle install .... instead of having to use the call bundle config set ... or have the --without test development and --path .. in the argument list.

e.g.

diff --git a/image/discourse_dev/Dockerfile b/image/discourse_dev/Dockerfile
index 9f9f4bf..fa42b65 100644
--- a/image/discourse_dev/Dockerfile
+++ b/image/discourse_dev/Dockerfile
@@ -66,7 +66,7 @@ USER discourse
 # Warm global bundle cache, then delete the compressed `cache/` versions (`/gem/` are enough)
 RUN --mount=type=bind,src=/repo,from=repo-fetcher,target=/tmp/discourse-clone,readwrite \
     cd /tmp/discourse-clone \
-    && bundle install --deployment \
+    && env BUNDLE_DEPLOYMENT=true bundle install \
     && rm -rf /home/discourse/.bundle/gems/ruby/*/cache/*
 
 # Warm global yarn cache

@davidtaylorhq davidtaylorhq deleted the drop-deprecated branch May 21, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants