docs: replace newSecretKey with newKeyPair in Ecdsa example.#218
Open
BruceJian43 wants to merge 1 commit intodint-dev:masterfrom
Open
docs: replace newSecretKey with newKeyPair in Ecdsa example.#218BruceJian43 wants to merge 1 commit intodint-dev:masterfrom
BruceJian43 wants to merge 1 commit intodint-dev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the
Ecdsaclass documentation example to use the correct key generation method.Changes
algorithm.newSecretKey()withalgorithm.newKeyPair().Reason
The previous example attempted to use
newSecretKey(), which is intended for symmetric algorithms. Since ECDSA is an asymmetric algorithm,newKeyPair()is the correct method to generate a private/public key pair.