add missing aad param for decryptString method.#217
Open
BirjuVachhani wants to merge 2 commits intodint-dev:masterfrom
Open
add missing aad param for decryptString method.#217BirjuVachhani wants to merge 2 commits intodint-dev:masterfrom
aad param for decryptString method.#217BirjuVachhani wants to merge 2 commits intodint-dev:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the missing aad (Additional Authenticated Data) parameter to the decryptString method, allowing callers to pass AAD when decrypting strings, which is necessary for AEAD (Authenticated Encryption with Associated Data) ciphers.
Changes:
- Added
aadparameter todecryptStringmethod with a default value of an empty list - Passed the
aadparameter through to the underlyingdecryptcall
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #216