Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the validation that prevented empty HMAC keys in the Dart implementation to support use cases like HKDF, where empty keys (or salts) are valid according to RFC 5869.
Key Changes
- Removed the
ArgumentErrorvalidation that enforced non-empty secret keys in_DartHmacSink.initializeSync() - Allows HMAC to be used with empty keys for algorithms like HKDF that may require this functionality
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
terrier989
force-pushed
the
fix/empty_hmac_key
branch
from
ed4b8ca to
e6dda65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty HMAC key can be useful in some situations like HKDF. See #176 .