Fix error with quote identifiers and uppercase identifiers#1701
Open
til wants to merge 1 commit intodimitri:masterfrom
Open
Fix error with quote identifiers and uppercase identifiers#1701til wants to merge 1 commit intodimitri:masterfrom
til wants to merge 1 commit intodimitri:masterfrom
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix fatal error when running with "quote identifiers" and the source has uppercase identifiers, as described in #1651. This PR simply contains the suggested fix from #1673 (comment)
Works for me, both with and without "quote identifiers", but I'm not familiar enough with pgloader to tell if it could have unintended consequences or if there is a better way.