Implement IsJoinIrreducible and IsMeetIrreducible#910
Draft
ThatOtherAndrew wants to merge 7 commits intodigraphs:mainfrom
Draft
Implement IsJoinIrreducible and IsMeetIrreducible#910ThatOtherAndrew wants to merge 7 commits intodigraphs:mainfrom
ThatOtherAndrew wants to merge 7 commits intodigraphs:mainfrom
Conversation
Author
|
Requesting a review from @james-d-mitchell please - how does this look? Is the PR description sufficiently detailed and mathematically accurate? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two new operations to section 10 (Operations for vertices) of
oper.gi/oper.gd:IsJoinIrreducible(D, v)— returnstrueif vertexvis not the join of any two distinct smaller nodes inDIsMeetIrreducible(D, v)— returnstrueif vertexvis not the meet of any two distinct larger nodes inDBoth were originally implemented by building the full O(N²) join/meet table, but then optimised to use
DigraphReflexiveTransitiveReduction, a function producing a Hasse diagram which allows for a computational shortcut (see SageMath docs below):https://doc.sagemath.org/html/en/reference/combinat/sage/combinat/posets/hasse_diagram.html#sage.combinat.posets.hasse_diagram.HasseDiagram.find_nontrivial_congruence
Tests are merged into
tst/standard/oper.tst, covering N5, a chain, B2, M3, and error handling (two test case sets written by myself and the rest with LLM assistance because I do not think my mathematical knowledge of the underlying concepts is strong enough to come up with reasonably comprehensive/diverse test cases).Closes #400