Conversation
…y user instead of drag and drop
Moved the custom order link to the spaces page. After cresting a new custom order, the application moves to the main custom order page and shows success message.
…page Added a success popup to indicate successful change of custom order selection Modified some css on spacelist.html
…into story/vspc-190 # Conflicts: # vspace/src/main/java/edu/asu/diging/vspace/web/staff/SpaceController.java
…into story/vspc-190
…into story/vspc-190
implemented review comments
…into story/vspc-190 # Conflicts: # vspace/src/main/java/edu/asu/diging/vspace/core/model/IExhibition.java # vspace/src/test/java/edu/asu/diging/vspace/core/services/impl/ExhibitionManagerTest.java
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
Member
|
Resolve conflicts please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
(you can copy the ticket if it hasn't changed)
Sitemap: a user should be able to define the order spaces appear in the site menu of the public page
Description
Right now, on the public site, the menu simply lists all published spaces. The user has no control over the order. For this ticket two things should be implemented:
by default the spaces should be ordered alphabetically by name
a user should be able to switch between alphabetically ordered, ordered by creation date, and a custom order.
For the custom order, there should be a page (on the staff side) that lists all spaces and the user can simply arrange them in the order they should be shown.
For this ticket, keep in mind that we might add a feature that allows users to create a nested sitemap (not this ticket though).
Anything else the reviewer needs to know?
... describe here ...