-
Notifications
You must be signed in to change notification settings - Fork 45
feat: advanced typography configuration #4450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ent and override in css
…ing + add half-steps
TODO the tokens get generated, but aren't connected in Figma (you have to manually re-apply them). Maybe due to not being in the same mode?
…ctured and we have backward-compatibility layer
…e>/<theme>/<font> tokens
|
Summary
This is a further development of #4044. While that has no breaking changes, it only allows configuring sizing for all themes/typography.
This change will be breaking for people who have started to use typography modes (primary/secondary) since those have been removed. It will also require some changes in the Figma Core UI Kit. However, I feel this is a much better path to take for supporting multiple fonts, and not many people have used typography modes yet due to it being half-baked so far with no config support.
Details
Example
designsystemet.config.jsonRemaining work
Further work is required before this is ready:
line-heightandletter-spacingto configurationChecks
pnpm changesetif relevant)