Conversation
Collaborator
Author
|
@zmx27 ready for review |
zmx27
reviewed
Oct 24, 2025
Collaborator
zmx27
left a comment
zmx27
left a comment
There was a problem hiding this comment.
Looks good. Only comment I have is that maybe you could try using package add news -n -m "<brief-reason>" next time so that trivial changes like these don't get compiled into the change log (you can find documentation of this command in scikit-package I believe)
Collaborator
Author
|
Thanks, I'll keep that in mind for other PRs. @sbillinge ready for review. |
sbillinge
reviewed
Oct 24, 2025
Contributor
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
nicely done. Just need the news fixed.
Collaborator
Author
|
@sbillinge does the update message suffice?
|
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
test-on-pr.ymlworkflow currently always fails because it tries to default to python version 3.14. I updated the workflow by specifying the version.