Skip to content

fix: resolve issue #82 - Badge hover preview - text#120

Open
cryst6line wants to merge 1 commit intodiffplug:mainfrom
cryst6line:fix/issue-82
Open

fix: resolve issue #82 - Badge hover preview - text#120
cryst6line wants to merge 1 commit intodiffplug:mainfrom
cryst6line:fix/issue-82

Conversation

@cryst6line
Copy link

Badge hover preview - text

This PR adds a tooltip that shows when you hover over text badges in draft comments. Before, there was no way to see what text was in the badge without clicking on it.

What changed

  • Added a tooltip component that displays when hovering over text badges
  • The tooltip shows the draft content from the badge
  • Updated the badge component to support the hover preview

Things to double-check

I want to flag one thing that came up in review: The tooltip currently shows plain text, but based on the issue description, it should probably display syntax-highlighted markdown instead. I started with plain text to get the basic functionality working, but if you want me to add markdown rendering with syntax highlighting, I can add that (would need to pull in something like react-markdown with a syntax highlighting plugin). Let me know if that's needed!

Testing

I ran the existing tests and they passed.


Hi, I'm fairly new to open source and this is one of my earlier contributions — I hope I haven't missed anything obvious. Please don't hesitate to point out anything I've done wrong, I really appreciate the feedback.

Sorry if this isn't quite right — happy to make any changes you need!

Show text preview tooltip when hovering over text badges in draft comments

Closes diffplug#82
Copy link
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only useful if it is doing the syntax highlighting. It should use the same syntax highlighting that gitcasso uses in the markdown bodies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants