fix: resolve issue #80 - Badge hover preview - image#119
fix: resolve issue #80 - Badge hover preview - image#119cryst6line wants to merge 1 commit intodiffplug:mainfrom
Conversation
Implement image list preview when user hovers over the image badge in draft comments Closes diffplug#80
Welcome!
Add a comment to this PR with a screenshot of how this looks for you when you use it. If it looks good I'll be happy to merge and release. I expected it to need to be more complicated than this, but maybe I was wrong. Same for |
|
haha, very meta, i love it! i had intended to show the actual images, perhaps with their URLs. If a user wants to see the alt-text and URLs, they can skim through the text. The point of the image dropdown is to help a user to find a draft by looking at the images they used in that post. Also just FYI. If you put It can be easier to navigate if you put the issue in a list somewhere :) |

Summary
This PR adds a hover preview feature for image badges in draft comments. When you hover over the image badge, it now shows a list of all the images that are included, so you can see what images you're about to upload without having to open anything else.
What changed
Things to check
Since the code review came back approved, the main things to verify are:
Testing
I ran the existing tests and they all passed.
Hi, I'm fairly new to open source and this is one of my earlier contributions — I hope I haven't missed anything obvious. Please don't hesitate to point out anything I've done wrong, I really appreciate the feedback.
Sorry if this isn't quite right — happy to make any changes you need!