Remove undefined-function-is-assume-false from goto-instrument#8783
Open
tautschnig wants to merge 1 commit intodiffblue:developfrom
Open
Remove undefined-function-is-assume-false from goto-instrument#8783tautschnig wants to merge 1 commit intodiffblue:developfrom
tautschnig wants to merge 1 commit intodiffblue:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8783 +/- ##
========================================
Coverage 80.01% 80.01%
========================================
Files 1700 1700
Lines 188345 188323 -22
Branches 73 73
========================================
- Hits 150696 150692 -4
+ Misses 37649 37631 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1f663d2 to
fd0dc19
Compare
There was a problem hiding this comment.
Pull request overview
Removes the --undefined-function-is-assume-false command-line option and its implementation from goto-instrument, directing users to replace it with --generate-function-body '.*' --generate-function-body-options assume-false.
Changes:
- Deleted
undefined_function_abort_pathAPI and implementation. - Removed CLI option parsing and help/manpage documentation for
--undefined-function-is-assume-false. - Updated
goto-instrumentoption list to no longer advertise the removed flag.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/goto-instrument/undefined_functions.h | Removes the declaration for the deleted undefined-function instrumentation helper. |
| src/goto-instrument/undefined_functions.cpp | Removes the implementation that rewrote undefined calls to assume(false). |
| src/goto-instrument/goto_instrument_parse_options.h | Drops the CLI option from the recognized options list. |
| src/goto-instrument/goto_instrument_parse_options.cpp | Removes runtime handling and --help text for the option. |
| doc/man/goto-instrument.1 | Removes the manpage entry for the deleted option. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Users can like-for-like replace such use with `--generate-function-body '.*' --generate-function-body-options assume-false`. Fixes: diffblue#2070
fd0dc19 to
7382807
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users can like-for-like replace such use with
--generate-function-body '.*' --generate-function-body-options assume-false.Fixes: #2070