Skip to content

fix: @logicflow/vue-node-registry 1.1.13版本打包没有js#2391

Merged
Zsynuting merged 4 commits intodidi:masterfrom
WXLKaylee:fix/vue-node-registry-1.1.13-build
Mar 20, 2026
Merged

fix: @logicflow/vue-node-registry 1.1.13版本打包没有js#2391
Zsynuting merged 4 commits intodidi:masterfrom
WXLKaylee:fix/vue-node-registry-1.1.13-build

Conversation

@WXLKaylee
Copy link

@WXLKaylee WXLKaylee commented Mar 19, 2026

Fixes #2386

修复 @logicflow/vue-node-registry 1.1.13版本打包没有js问题;
原因:/LogicFlow/packages/vue-node-registry/src/view.ts 中 disconnect 缺少必要参数。
image

wuxuelan added 2 commits March 19, 2026 19:38
@logicflow/vue-node-registry@1.1.14-alpha.1
@changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2026

⚠️ No Changeset found

Latest commit: 0dfdfff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@WXLKaylee WXLKaylee changed the title feat: release new version fix: @logicflow/vue-node-registry 1.1.13版本打包没有js Mar 19, 2026
@Zsynuting Zsynuting requested a review from Copilot March 19, 2026 13:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the build failure in @logicflow/vue-node-registry@1.1.13 by updating Vue Teleport cleanup calls to match the disconnect(id, flowId) function signature.

Changes:

  • Pass flowId as the required second argument to disconnect(...) in VueNodeView when cleaning up Teleport mounts in early-return branches.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines 100 to 103
// Config exists but has no component; also clean up any existing Teleport mount
if (isVue3 && isActive()) {
disconnect(this.targetId())
disconnect(this.targetId(), this.props.graphModel.flowId as string)
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Zsynuting
Zsynuting previously approved these changes Mar 19, 2026
@Zsynuting Zsynuting merged commit 77bf7a8 into didi:master Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report]: @logicflow/vue-node-registry@1.1.13 最新的版本 出现打包的问题

3 participants