-
Notifications
You must be signed in to change notification settings - Fork 29
Added support for config file properties injection #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
galarragas
wants to merge
10
commits into
dickwall:master
Choose a base branch
from
galarragas:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,12 +7,19 @@ package com.escalatesoft.subcut.inject | |||
| * Time: 11:39 AM | |||
| */ | |||
| import scala.collection._ | |||
| import com.escalatesoft.subcut.inject.config._ | |||
| import com.escalatesoft.subcut.inject.config.Undefined | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the "import .....config.Undefined" really needed ? (as you imported the entire package before)
|
That's cool stuff, like it 👍 |
…e approved. Fixed problems of lack of config support when mofidying the module with modifyBindings
…configuration if necessary
SBT Plugins dependencies and repositories were obsolete and needed to be updated to get the project building again.
Fix SBT Plugins dependencies
Scala 2.9.x is largely obsolete and subcut wasn't compiling on it anyway.
Conflicts: build.sbt pom.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using subcut in some of my projects and I wanted to simplify the use case in which an object needs to retrieve some of the properties from configuration files.
I added some feature to implement injection similarly to the @value annotation in spring. For example:
Allowing to inject in this way:
It supports injection of basic types and allows generic types injection if a custom conversion function is provided.
I think it can help in simplify the code a lot. At least is doing it in my current work.