Skip to content

docs: improve Javadocs for OAuth2 Dynamic Client Registration#23741

Merged
netroms merged 1 commit into
masterfrom
docs/javadocs-android-dcr
Apr 29, 2026
Merged

docs: improve Javadocs for OAuth2 Dynamic Client Registration#23741
netroms merged 1 commit into
masterfrom
docs/javadocs-android-dcr

Conversation

@netroms
Copy link
Copy Markdown
Contributor

@netroms netroms commented Apr 24, 2026

Summary

Part 2 of 3 splitting #23734 into smaller PRs per reviewer request. This PR covers the DHIS2 Dynamic Client Registration (DCR) flow used by the Android Capture app to enroll each device as its own first-party OAuth2 client authenticated with `private_key_jwt`.

3 classes, Javadoc only, aligned with the user-facing OAuth2 / OIDC / JWT reference in dhis2-docs#1739:

  • `OAuth2DcrService` — creates the reserved `system-dcr-registrar-client` at startup and mints one-time Initial Access Tokens (IATs).
  • `OAuth2DynamicClientRegistrationController` — `GET /api/auth/enrollDevice`, the first step of the two-step enrollment that redirects to the device with an IAT.
  • `InlineJwksJwtClientAssertionDecoderFactory` — the Spring AS `JwtClientAssertionDecoderFactory` extension that reads inline JWKS from `ClientSettings` so Android-registered clients can authenticate with `private_key_jwt` without hosting a public `jwks_uri`.

Companion PRs:

  • SAS core: docs/javadocs-sas
  • OIDC login + JWT bearer: docs/javadocs-oidc-login-jwt

AI Assisted

Align Javadocs on the DCR flow (OAuth2DcrService,
OAuth2DynamicClientRegistrationController,
InlineJwksJwtClientAssertionDecoderFactory) with the user-facing OAuth2
reference. Describes the two-step Android device enrollment: the IAT
mint step (GET /api/auth/enrollDevice) and the RFC 7591 registration
step (/connect/register), plus the inline-JWKS path used when the
registered client later authenticates at /oauth2/token with
private_key_jwt.

No behavior, signatures, imports, or annotations were changed.

AI Assisted
@sonarqubecloud
Copy link
Copy Markdown

@netroms netroms merged commit 7a8aaa5 into master Apr 29, 2026
16 checks passed
@netroms netroms deleted the docs/javadocs-android-dcr branch April 29, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants