Skip to content

Conversation

@jenniferarnesen
Copy link
Collaborator

@jenniferarnesen jenniferarnesen commented Oct 29, 2025

Implements DHIS2-20362

Description

The interpretations panel was not being displayed when clicking the Interpretations toggler. This seems to be because adding the right panel did not trigger a resize event, so the pivot table doesn't get resized, and the right panel width stays at 0 even though its content is 380px wide.

With the fix, the VisualizationPlugin calculates the available width when the panel is opened/closed, and passes that to the PivotTable component.

This should have no effect on dashboard or on charts, but it's not a bad idea to confirm.


Quality checklist

Add N/A to items that are not applicable.

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Oct 30, 2025

🚀 Deployed on https://pr-3445.data-visualizer.netlify.dhis2.org

@dhis2-bot dhis2-bot temporarily deployed to netlify October 30, 2025 08:17 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify October 30, 2025 08:24 Inactive
jenniferarnesen and others added 6 commits October 30, 2025 09:34
* fix: use interpretations provider from analytics

* chore: upgrade analytics

* chore: update analytics

* chore: update analytics to v29.0.1
## [101.3.3](v101.3.2...v101.3.3) (2025-10-29)

### Bug Fixes

* use interpretations provider from analytics [DHIS2-19822] ([#3438](#3438)) ([2ab40fc](2ab40fc))
@jenniferarnesen jenniferarnesen force-pushed the fix/pivot-interpretations-panel branch from 2601d81 to 580d1a0 Compare October 30, 2025 08:35
@dhis2-bot dhis2-bot temporarily deployed to netlify October 30, 2025 08:38 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify October 30, 2025 08:58 Inactive
@jenniferarnesen jenniferarnesen marked this pull request as ready for review October 30, 2025 09:01
@dhis2-bot dhis2-bot temporarily deployed to netlify November 5, 2025 08:53 Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 5, 2025

@dhis2-bot dhis2-bot temporarily deployed to netlify November 5, 2025 09:33 Inactive
@HendrikThePendric HendrikThePendric self-requested a review November 5, 2025 10:04
@jenniferarnesen jenniferarnesen merged commit d50cf53 into master Nov 5, 2025
33 checks passed
@jenniferarnesen jenniferarnesen deleted the fix/pivot-interpretations-panel branch November 5, 2025 10:11
dhis2-bot added a commit that referenced this pull request Nov 5, 2025
## [101.3.5](v101.3.4...v101.3.5) (2025-11-05)

### Bug Fixes

* interpretations panel not displaying for pivot tables ([#3445](#3445)) ([d50cf53](d50cf53))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.3.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants