fix(offline): clear SWR caches betwen users [LIBS-358] #1268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaiVandivier
commented
Oct 18, 2022
| // Non-sensitive caches that can be kept: | ||
| const KEEPABLE_CACHES = [ | ||
| /^workbox-precache/, // precached static assets | ||
| /^other-assets/, // static assets cached at runtime - shouldn't be sensitive |
Contributor
Author
There was a problem hiding this comment.
This line is the main change. The rest are to update tests and satisfy typescript
amcgee
approved these changes
Oct 23, 2022
Member
amcgee
left a comment
amcgee
left a comment
There was a problem hiding this comment.
Looks good! See dhis2/app-platform#762 (review)
KaiVandivier
force-pushed
the
libs-358-fix-remove-other-assets-btwn-users
branch
from
f3915d9 to
7b5aa00
Compare
dhis2-bot
added a commit
that referenced
this pull request
Oct 24, 2022
## [3.6.1](v3.6.0...v3.6.1) (2022-10-24) ### Bug Fixes * **offline:** clear SWR caches betwen users [LIBS-358] ([#1268](#1268)) ([fc0d143](fc0d143))
Contributor
|
🎉 This PR is included in version 3.6.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://dhis2.atlassian.net/browse/LIBS-356
This PR is related to but independent of dhis2/app-platform#757
This is in case some sensitive data ends up in the SWR cache, which is intended for files to be cached at runtime, but might end up caching something
.jsonor.actiondata (though those extensions are being filtered in platform PR 757 above)