Skip to content

Pr 36050 #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dheerajbstack wants to merge 8 commits into
base: main
Choose a base branch
from
+37 −5
Open

Pr 36050 #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b1b1d1b
Initial plan for issue
Copilot May 22, 2025
2f61033
Fix ConsoleMessage.type() return type
Copilot May 22, 2025
f020386
Update ConsoleMessage.type() to return specific string literals
Copilot May 22, 2025
a3fc46b
fix(types): update ConsoleMessage position in overrides.d.ts
Copilot May 22, 2025
b486b66
fix(types): update ConsoleMessage.type() return type without moving t…
Copilot May 22, 2025
e0f1c32
fix(types): fix lint error by updating ConsoleMessage.type() implemen…
Copilot May 23, 2025
fe993b8
Remove .original file from PR as requested
Copilot May 23, 2025
569e3d0
fix(types): update ConsoleMessage.type in protocol.yml and docs
Copilot May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions docs/src/api/class-consolemessage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,16 @@ The text of the console message.

## method: ConsoleMessage.type
* since: v1.8
* langs: js
- returns: <[ConsoleMessageType]>

One of the following values: `'log'`, `'debug'`, `'info'`, `'error'`, `'warning'`, `'dir'`, `'dirxml'`, `'table'`,
`'trace'`, `'clear'`, `'startGroup'`, `'startGroupCollapsed'`, `'endGroup'`, `'assert'`, `'profile'`, `'profileEnd'`,
`'count'`, `'timeEnd'`.

## method: ConsoleMessage.type
* since: v1.8
* langs: csharp, java, python
- returns: <[string]>

One of the following values: `'log'`, `'debug'`, `'info'`, `'error'`, `'warning'`, `'dir'`, `'dirxml'`, `'table'`,
Expand Down
2 changes: 1 addition & 1 deletion packages/playwright-client/types/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18838,7 +18838,7 @@ export interface ConsoleMessage {
* `'trace'`, `'clear'`, `'startGroup'`, `'startGroupCollapsed'`, `'endGroup'`, `'assert'`, `'profile'`,
* `'profileEnd'`, `'count'`, `'timeEnd'`.
*/
type(): string;
type(): ConsoleMessageType;
}

/**
Expand Down
4 changes: 2 additions & 2 deletions packages/playwright-core/src/client/consoleMessage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ export class ConsoleMessage implements api.ConsoleMessage {
return this._page;
}

type(): string {
return this._event.type;
type(): ReturnType<api.ConsoleMessage["type"]> {
return this._event.type as ReturnType<api.ConsoleMessage["type"]>;
}

text(): string {
Expand Down
2 changes: 1 addition & 1 deletion packages/playwright-core/types/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18838,7 +18838,7 @@ export interface ConsoleMessage {
* `'trace'`, `'clear'`, `'startGroup'`, `'startGroupCollapsed'`, `'endGroup'`, `'assert'`, `'profile'`,
* `'profileEnd'`, `'count'`, `'timeEnd'`.
*/
type(): string;
type(): ConsoleMessageType;
}

/**
Expand Down
24 changes: 23 additions & 1 deletion packages/protocol/src/protocol.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1147,10 +1147,32 @@ Browser:

close:

ConsoleMessageType:
type: enum
literals:
- log
- debug
- info
- error
- warning
- dir
- dirxml
- table
- trace
- clear
- startGroup
- startGroupCollapsed
- endGroup
- assert
- profile
- profileEnd
- count
- timeEnd

ConsoleMessage:
type: mixin
properties:
type: string
type: ConsoleMessageType
text: string
args:
type: array
Expand Down
Loading