-
Notifications
You must be signed in to change notification settings - Fork 41
Please review my Day1 assignment #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Day1/assignment.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent the code properly like below. 2 spaces. It looks like editor settings. Ask your friends 👍
|
Hi @shyam-sharma , Reviewed your code. Check indentation from next time onwards. It looks like editor setting. |
|
@budhrg please review Day1 updated assignment and Day2 Array assignment. |
|
Hi @vitthalgaikwad, Please review the assignments. |
Day1/assignment.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shyam-sharma you should use string interpolation here according to question.
|
@vitthalgaikwad assignment is updated, Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Best for this small assignment. But ideal answer is using map function. In real world, the length of array is unknown and this solution will not be work for large array. 😄
|
@budhrg @vitthalgaikwad Hi, Please review Day2 assignment of Control_statements. |
@budhrg Please review my Day1 assignment