Skip to content

Conversation

@shyam-sharma
Copy link

@budhrg Please review my Day1 assignment

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent the code properly like below. 2 spaces. It looks like editor settings. Ask your friends 👍

@brgnepal
Copy link
Collaborator

Hi @shyam-sharma ,

Reviewed your code. Check indentation from next time onwards. It looks like editor setting.

@shyam-sharma
Copy link
Author

@budhrg please review Day1 updated assignment and Day2 Array assignment.

@brgnepal
Copy link
Collaborator

Hi @vitthalgaikwad,

Please review the assignments.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shyam-sharma you should use string interpolation here according to question.

@shyam-sharma
Copy link
Author

@vitthalgaikwad assignment is updated, Please review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Best for this small assignment. But ideal answer is using map function. In real world, the length of array is unknown and this solution will not be work for large array. 😄

@shyam-sharma
Copy link
Author

@budhrg @vitthalgaikwad Hi, Please review Day2 assignment of Control_statements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants