-
Notifications
You must be signed in to change notification settings - Fork 3
Configure codecov to check for 100% unit test coverage #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant CI
participant Codecov
Developer->>CI: Pushes code
CI->>Codecov: Uploads coverage reports
Codecov->>CI: Evaluates coverage for "app" (src/) context (95%)
Codecov->>CI: Evaluates coverage for "tests" (tests/) context (100%)
CI->>Developer: Reports status for each context
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
codecov.yml (1)
5-8: Consider setting an explicit coverage threshold and glob pattern for “app”
Usingtarget: autorelies on Codecov’s default (often 80% or the badge-configured value), which may drift over time. Specifying95%makes your intent explicit. Likewise, updating the path to a glob (src/**) ensures all subdirectories are included.Diff proposal:
app: - target: auto # default target (95%) + target: 95% # enforce 95% coverage for application code - paths: - - "src/" # limit to files within src code directory + paths: + - "src/**" # include all files under src/
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
codecov.yml(1 hunks)
🔇 Additional comments (2)
codecov.yml (2)
1-4: Disabling default coverage status check intentionally configured
Thedefault: falsesetting at the project level correctly disables the global status check, allowing you to define fine-grained contexts below.
9-12: Verify the “test/” path and 100% threshold for tests context
Requiring 100% coverage on the test code itself is unusual since test files rarely invoke all their own lines (and may not be imported). Please confirm:
- Your test directory is actually named
test/(nottests/).- That Codecov counts test-file coverage as expected.
If the directory is
tests/, update the path accordingly.
ec41ca3 to
916ab7f
Compare
Summary by CodeRabbit