feat: add support for CHIPS partitioned cookies #62
+124
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsteel
requested changes
Aug 5, 2025
Setting withPartitioned() will also set withSecure()
gsteel
requested changes
Aug 6, 2025
Co-authored-by: George Steel <george@netglue.uk>
gsteel
requested changes
Aug 13, 2025
Collaborator
gsteel
left a comment
gsteel
left a comment
There was a problem hiding this comment.
Can you please fix CS issues? Otherwise LGTM. Once CI is green, I'll release when I get the chance
Contributor
Author
|
Sorry to be such a drag on itty-bitty fixes! Thanks for bearing with me. |
Collaborator
No worries 👍 Try running |
Contributor
Author
|
Huh. I ran php-cs-fixer, didn’t catch everything huh? Just a sec.
…On Aug 13, 2025 at 8:12:47 AM, George Steel ***@***.***> wrote:
*gsteel* left a comment (dflydev/dflydev-fig-cookies#62)
<#62 (comment)>
Sorry to be such a drag on itty-bitty fixes! Thanks for bearing with me.
No worries 👍
Try running ./vendor/bin/phpcs and ./vendor/bin/phpcbf locally
—
Reply to this email directly, view it on GitHub
<#62 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADGOIZGILFU6O6QUX45YLD3NMTT7AVCNFSM6AAAAACDE76K72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCOBTGU4TQNJWG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.