fix(orchestrator): mock starting processes in upgrade unit tests#9528
Draft
pierugo-dfinity wants to merge 2 commits intomasterfrom
Draft
fix(orchestrator): mock starting processes in upgrade unit tests#9528pierugo-dfinity wants to merge 2 commits intomasterfrom
pierugo-dfinity wants to merge 2 commits intomasterfrom
Conversation
…tests (#9521) This PR deflakes `//rs/orchestrator:orchestrator_test` by mocking the process management of the orchestrator such that no process is actually spawned when the upgrade loop supposedly starts the replica. To do so, this moves the struct `ProcessManager` to a trait that exposes the public functions and leaves the implementation to `ProcessManagerImpl`. Now, a `FakeProcessManager` can be used, whose implementation is keeping track of a boolean mocking whether the process is running or not. This was mostly AI-generated, supervised and reviewed by me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.