Open
Conversation
…all-targets --workspace -- --deny clippy::unseparated_literal_suffix. More than 1000 fixed literals over 204 files. Once this goes in, enforcement will be enabled via PR 9452.
daniel-wong-dfinity-org
force-pushed
the
omnibus-separate-numeric-type-suffix-daniel-wong
branch
from
daad1da to
40492e6
Compare
daniel-wong-dfinity-org
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
github-actions
bot
added
@ic-interface-owners
@consensus
@governance-team
@defi
@idx
@node
labels
basvandijk
approved these changes
Mar 20, 2026
mducroux
approved these changes
Mar 20, 2026
daniel-wong-dfinity-org
dismissed
github-actions[bot]’s stale review
This is completely behavior preserving.
pierugo-dfinity
approved these changes
Mar 20, 2026
Contributor
pierugo-dfinity
left a comment
pierugo-dfinity
left a comment
There was a problem hiding this comment.
Do you know why your first PRs missed those instances?
Contributor
Author
I think because AI tried to partition the code by team from .github/CODEOWNERS, which I guess is not so easy to do correctly, and as a result, the partition was not complete for whatever reason. Another reason is that I did not fix 3.14f64 (to 3.14_f64), only integers, because I used a custom tool (with the help of AI), not |
Bownairo
approved these changes
Mar 20, 2026
alin-at-dfinity
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is done via
More than 1000 fixed literals over 204 files. Once this goes in, enforcement will be enabled via PR 9452 (already approved by IDX).
Verifying This PR
To verify this PR, reproduce it by first checking out
30270d6186ec6d7fdc6080821bfdec3c4d6cd30c. Then, run the above command. Then,The
git diff ...command should print nothing (meaning, that your run ofcargo clippy --fix ...made the same edits as what's in the branch of this PR).Prior Work
Earlier, I sent out a batch of PRs (one PR per team) that tried to fix everything, but it somehow missed a bunch of instances of 42u64. This SHOULD clean up the rest.