refactor: [DSM-103] Switch to was_fully_executed()#9499
Open
alin-at-dfinity wants to merge 2 commits intomasterfrom
Open
refactor: [DSM-103] Switch to was_fully_executed()#9499alin-at-dfinity wants to merge 2 commits intomasterfrom
was_fully_executed()#9499alin-at-dfinity wants to merge 2 commits intomasterfrom
Conversation
Switch from directly checking CanisterPriority::last_full_execution_round to was_fully_executed(). In the future, not all canisters will have a CanisterPriority at all times, so we'll have a different implementation for was_fully_executed().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch from directly checking
CanisterPriority::last_full_execution_roundtowas_fully_executed(). In the future, not all canisters will have aCanisterPriorityat all times, so we'll have a different implementation forwas_fully_executed().