fix(ckdoge): use legacy P2PKH transactions for withdrawals #8187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorydemay
changed the title
This was referenced Dec 23, 2025
mducroux
approved these changes
Dec 29, 2025
Contributor
mducroux
left a comment
mducroux
left a comment
There was a problem hiding this comment.
Thanks for the fix @gregorydemay. LGTM!
ninegua
approved these changes
Dec 29, 2025
Member
ninegua
left a comment
ninegua
left a comment
There was a problem hiding this comment.
Thanks! LGTM. Btw, do you know how much the ckdoge canister size changed due to the new bitcoin-dogecoin dependency?
gregorydemay
commented
Dec 29, 2025
Contributor
Author
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
Forgot to push my previous comments, sorry about that
mducroux
reviewed
Dec 30, 2025
mducroux
approved these changes
Dec 30, 2025
Contributor
mducroux
left a comment
mducroux
left a comment
There was a problem hiding this comment.
Thanks for this @gregorydemay! Left only a few minor comments
ninegua
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the withdrawal of ckDOGE to DOGE. Transactions created by the ckDOGE minter are quite different to the ones from the ckBTC minter:
Transactions created by the ckDOGE minter are therefore widely different from the ones created by the ckBTC minter, which requires a separate implementation. In particular, the choice here is to use the Rust bitcoin library to create such transactions instead of tweaking the custom implementation used by the ckBTC minter.
Those problems also show the insufficiency of the current integration tests, which only mock the Dogecoin canister and therefore do not ensure the validity of the transactions created by the minter. This part is left for future work. The current PR was tested locally on Regtest and with the ckDOGE staging canister which successfully produced the transaction 32d24dcb.