fix: Address "VM is running" check issues #7458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wait_for_shutdown used to call is_running which returned true iff the domain existed and was in `VIR_DOMAIN_RUNNING` state. However, we've observed that the code misbehaves intermittently, according to our theory: - the VM is in `VIR_DOMAIN_SHUTDOWN` state - we decide the VM is not running - we try to clean up the temporary files which fails The new logic: - If domain exists and running: all good (no changes here) - If domain exists but in crashed state: consider dead and log - If domain exists and is in any other state: consider running and log - If domain does not exist or its state cannot be queried: consider dead and log
andrewbattat
approved these changes
Oct 28, 2025
Bownairo
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_running
wait_for_shutdownused to callis_runningwhich returned true iff the domain existed and was inVIR_DOMAIN_RUNNINGstate. However, we've observed that the code intermittently misbehaves.According to our theory:
VIR_DOMAIN_SHUTDOWNstateis_runningreturn falsewait_for_shutdownreturnsThe new logic:
try_destroy_existing_vm
We change the implementation to include a call to undefine. This may help remove the VM if it's in an odd state where it's defined but is not running.