feat: CON-1670 Add some DKG metrics & avoid proposing empty IDKG payloads#10121
Merged
Conversation
eichhorl
changed the title
pierugo-dfinity
approved these changes
May 12, 2026
Contributor
pierugo-dfinity
left a comment
pierugo-dfinity
left a comment
There was a problem hiding this comment.
This is dangerous since we could silently loose the master keys on the subnet
AFAICT, others would not validate the block as they would either compute the actual summary or also hit an error no? I still agree that it makes more sense to not propose the block in case of an error though.
Contributor
Author
Good point, and data blocks would be rejected with |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add metrics for
Additionally, we change the way IDKG payload creation errors are handled: Previously, if no IDKG payload could be created, the block maker would instead propose a block without an IDKG payload. This is dangerous since we could silently loose the master keys on the subnet, even if the reason for the payload creation failure was potentially transient.
After this PR, if IDKG payload creation fails, we will not propose a block. Instead we will try again later, or wait until we receive a block from different block maker.