chore(CI): auto-close forks targeting the ai feature branch#10101
Open
NikolaMilosa wants to merge 4 commits intomasterfrom
Open
chore(CI): auto-close forks targeting the ai feature branch#10101NikolaMilosa wants to merge 4 commits intomasterfrom
NikolaMilosa wants to merge 4 commits intomasterfrom
Conversation
basvandijk
reviewed
May 6, 2026
Collaborator
basvandijk
left a comment
basvandijk
left a comment
There was a problem hiding this comment.
It's unexpected to find the check-external-branch-policy job in the external-contrib-slack-notification.yaml workflow since the former has nothing to do with slack notifications. What about moving it into a dedicated workflow?
basvandijk
reviewed
May 6, 2026
|
|
||
| on: | ||
| pull_request_target: | ||
| types: [opened, reopened] |
Collaborator
There was a problem hiding this comment.
What happens when you retarget an already open PR? Will this still get triggered?
Contributor
Author
There was a problem hiding this comment.
Based on this I don't see an event type for that. Which events would you suggest we add?
Collaborator
There was a problem hiding this comment.
I would guess edited since you have to click the edit title button to change the target branch. But you'll have to test it to be sure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this branch is meant for internal development, this PR is closing all prs that target specific feature branches