Conversation
nabokihms
left a comment
There was a problem hiding this comment.
Overall, looks good. Some minor suggestions. And there are also conflicts.
Signed-off-by: Ivan Zvyagintsev <ivan.zvyagintsev@flant.com>
Signed-off-by: Ivan Zvyagintsev <ivan.zvyagintsev@flant.com>
Signed-off-by: Ivan Zvyagintsev <ivan.zvyagintsev@flant.com>
d5ff7e9 to
d53acc6
Compare
|
All good from my side here. @sagikazarmark do you have any objections to merging this? |
|
We tracked a Kerberos/SPNEGO issue in the LDAP connector implementation from branch What we observed
Errors observed in the connector flow
Issues found
What fixed it
Effective behavior that worked
With these changes applied, the connector is now deployed and fully working for our client in production-like use. I am attaching the patch that implements these changes. https://gist.github.com/KubaFajny/4d1c7c8f3816591642eb397b62b67ed6 |
Overview
Add Kerberos/SPNEGO Single Sign-On support for the LDAP connector, enabling seamless authentication for users in Active Directory/Kerberos environments without requiring password entry.
What this PR does / why we need it
This PR adds optional Kerberos (SPNEGO) authentication to the LDAP connector. When enabled, Dex can authenticate users via the
Authorization: Negotiateheader on the password login endpoint, completing the OIDC flow without rendering the password form.Why we need it:
Key features:
localpart,sAMAccountName, oruserPrincipalName)Configuration example:
Special notes for your reviewer
SPNEGOAwareinterface inconnector/spnego.gois designed to be generic, allowing other connectors to implement SPNEGO in the future if neededconnector/ldap/kerberos.gofor maintainability