Turn arm builds back on, we need them for mac development#2
Conversation
WalkthroughUpdated the GitHub Actions build workflow to compile Docker images for multiple architectures (linux/amd64 and linux/arm64/v8) instead of a single architecture during non-main branch builds, enabling broader platform support. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/build.yaml (1)
76-92: Verify that always building arm64 on feature branches aligns with team expectations.The change correctly enables multi-architecture builds with proper QEMU and Buildx setup. However, building for both
linux/amd64andlinux/arm64/v8on every commit—including to feature branches—will significantly increase CI build times due to QEMU-based cross-compilation overhead. The arm64 images aren't pushed on non-main branches (line 91), so the additional build cost provides no immediate benefit outside of main.Consider making arm64 builds conditional to optimize CI efficiency:
- platforms: linux/amd64,linux/arm64/v8 + platforms: ${{ github.ref_name == 'main' && 'linux/amd64,linux/arm64/v8' || 'linux/amd64' }}This reserves multi-arch builds for main branch, where images are actually pushed, while keeping feature branch builds fast for rapid iteration.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/build.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Build Image (pg17)
- GitHub Check: Build Image (pg15)
- GitHub Check: Build Image (pg16)
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.