Remove xcodeproj & xcshareddata ignores #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `.gitignore` file currently is ignoring xcodepoj-related files, which currently does nothing for the Then project because of the decision to go full SPM and remove all xcodeproj stuff (#55). However, ignoring these files causes issues when Then's source is included in outer Git repo (via git-subtree or direct copying of project) such as when using Carthage or manual library management in conjunction with a generated xcodeproj (`swift package generate-xcodeproj`). Because Then's `.gitignore` is picked up by the enclosing repo, that prevents the generated xcodeproj or shared schemes from being able to be checked-in— which should arguably be under the discretion of the enclosing repo's build setup. Removed the ignores for xcodeproj and xcshareddata to fix this, and removed the xcuserdata line too for good measure _(again, if there's no xcodeproj in Then, there's no need to ignore it)_.
Contributor
Author
|
BTW, If a dev is working on the Then project itself and needs to generate an xcodeproj (rather than using Xcode 11's Swift package-project mode) but is afraid of accidentally committing it (or just hates non-clean working directories like I do), these ignores can be easily added to one's only local-repo-only in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.gitignorefile currently is ignoring xcodepoj-related files, which currently does nothing for the Then project because of the decision to go full SPM and remove all xcodeproj stuff (#55).However, ignoring these files causes issues when Then's source is included in outer Git repo (via git-subtree or direct copying of project) such as when using Carthage or manual library management in conjunction with a generated xcodeproj (
swift package generate-xcodeproj). Because Then's.gitignoreis picked up by the enclosing repo, that prevents the generated xcodeproj or shared schemes from being able to be checked-in— which should arguably be under the discretion of the enclosing repo's build setup. Removed the ignores for xcodeproj and xcshareddata to fix this, and removed the xcuserdata line too for good measure (again, if there's no xcodeproj in Then, there's no need to ignore it).