Open
Conversation
In Swift 6 language mode, non-escaping closures automatically inherit the caller's actor isolation. This resolves the type mismatch error when using then/with/do with @MainActor-isolated types such as UIKit classes. Closes #106
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Swift 6 strict concurrency error when using
then/with/dowith@MainActor-isolated types such as UIKit classes.Closes #106
Problem
In Swift 6 strict concurrency, calling
thenon a@MainActor-isolated type likeUIStackViewproduces:This happens because the library was compiled with
swift-tools-version:5.0(Swift 5 language mode), where non-escaping closures do not inherit the caller's actor isolation.Changes
Package.swift
swift-tools-versionfrom5.0to6.0. In Swift 6 language mode, non-escaping closure parameters automatically inherit the caller's actor isolation — no API changes needed.Tests
@MainActor-annotated tests validating thatthen,with, anddocompile and behave correctly with@MainActor-isolated types.Context
swift-tools-version:6.0requires Swift 6 tooling.Testing
testThen_MainActorIsolated,testWith_MainActorIsolated,testDo_MainActorIsolated) verify the fix.Summary by cubic
Fixes Swift 6 strict concurrency errors when calling
then/with/doon@MainActor-isolated types by buildingThenin Swift 6 mode. Also updates minimum platform versions, adds@MainActortests, and sets TuistSWIFT_VERSIONto 6.0.swift-tools-version: 6.0).Thenrelease.Written for commit 3b2f791. Summary will update on new commits.