fix(dist): sign, notarize, and staple macOS desktop builds#96
Open
ibourgeois wants to merge 3 commits intomainfrom
Open
fix(dist): sign, notarize, and staple macOS desktop builds#96ibourgeois wants to merge 3 commits intomainfrom
ibourgeois wants to merge 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the macOS “Tagged Release” pipeline to produce trusted desktop release artifacts by enforcing Developer ID signing and Apple notarization, then stapling tickets to the resulting deliverables. It also updates user-facing and contributor documentation to reflect the new signed/notarized macOS release path and required repository secrets.
Changes:
- Adds CI validation of required macOS signing/notarization secrets and imports a Developer ID Application certificate into a temporary keychain.
- Enables signing/notarization in the macOS release build, verifies signatures, notarizes + staples the DMG (and staples the app bundle), and uploads DMG + SHA256 assets.
- Updates README and NativePHP docs to describe trusted macOS releases and the new secret requirements.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| README.md | Updates end-user messaging about trusted (signed/notarized/stapled) tagged macOS releases. |
| docs/development/nativephp.md | Documents the new signing/notarization flow and required GitHub secrets for releases. |
| .github/workflows/tagged-release.yml | Implements signing, notarization, stapling, and clearer failure modes for macOS tagged releases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63
Status
Blocked pending Apple Developer organization enrollment approval.
Please do not merge this PR until Apple finishes verifying authority to sign legal agreements and the required GitHub repository secrets are configured. If it merges before that, the next release-driving merge will fail in the macOS signing workflow.
Summary
Verification
ruby -e 'require "yaml"; YAML.load_file(".github/workflows/tagged-release.yml"); puts "tagged-release.yml ok"'git diff --checkRequired GitHub Secrets
MACOS_DEVELOPER_ID_APPLICATION_CERTIFICATE_P12_BASE64MACOS_DEVELOPER_ID_APPLICATION_CERTIFICATE_PASSWORDMACOS_NOTARY_APPLE_IDMACOS_NOTARY_APP_SPECIFIC_PASSWORDMACOS_NOTARY_TEAM_ID