Add support for multi-source input (Issue #33)#119
Open
dobon wants to merge 2 commits intodevongovett:masterfrom
Open
Add support for multi-source input (Issue #33)#119dobon wants to merge 2 commits intodevongovett:masterfrom
dobon wants to merge 2 commits intodevongovett:masterfrom
Conversation
dobon
commented
Sep 17, 2018
- Add support for multi-source input via using an array of specially formulated objects as input.
- Add spec to test multi-source input covering use of 'page', 'toc' and 'cover' page types, global options, optional arguments and page-specific options. I think this is fairly complete, but more tests could be added.
- Update README.md to explain how to use multi-source input.
- Refactor the options-to-arguments part of code into a helper function for reuse in both single and multi-source input use cases.
- Refactor code location of array of valid ToC options and added array of valid global options. This could be extended to include header and footer options, and page-specific options, and could then be used to validate options.
Author
|
@devongovett Can someone help me debug why this PR failed the CI test? |
Collaborator
|
@dobon travis was fixed, can you rebase this with master and let it run thru travis again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.